fix(controller): Revert parameter value to *string. Fixes #3960
#3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
added
type/bug
type/regression
alexec
changed the title
*string. Fixes #3960
simster7
reviewed
Sep 10, 2020
| @@ -610,11 +610,11 @@ type Parameter struct { | |||
| Name string `json:"name" protobuf:"bytes,1,opt,name=name"` | |||
|
|
|||
| // Default is the default value to use for an input parameter if a value was not supplied | |||
| Default *intstr.IntOrString `json:"default,omitempty" protobuf:"bytes,2,opt,name=default"` | |||
| Default *string `json:"default,omitempty" protobuf:"bytes,2,opt,name=default"` | |||
There was a problem hiding this comment.
I think this value is wholly unused. Can we remove it?
There was a problem hiding this comment.
I thought that, but I actually think it's used in some weird and non-obvious dynamic way .
|
@jessesuen can you please approve this PR? It is a revert to v2.9 code and needs to be back-ported to v2.10 and v2.11. |
jessesuen
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.Fixes #3960
IntStris a misnomer. It cannot handle integer values (specifically int64). This PR reverts to v2.9