-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): Panic or error on mis-matched resource version #3949
Conversation
status: | ||
phase: Running | ||
startedAt: "2020-07-14T16:26:21Z" | ||
limit: 2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" is missing
@@ -614,6 +617,7 @@ func TestDagAssessPhaseContinueOnExpandedTaskVariables(t *testing.T) { | |||
woc := newWorkflowOperationCtx(wf, controller) | |||
|
|||
woc.operate() | |||
woc = newWorkflowOperationCtx(woc.wf, controller) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to create a new context here? we can just use woc.operate() which will have updated wf.
@@ -835,6 +839,7 @@ func TestDagAssessPhaseContinueOnExpandedTask(t *testing.T) { | |||
woc := newWorkflowOperationCtx(wf, controller) | |||
|
|||
woc.operate() | |||
woc = newWorkflowOperationCtx(woc.wf, controller) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same above
@@ -1765,6 +1771,7 @@ func TestOnExitNonLeaf(t *testing.T) { | |||
|
|||
retryNode.Phase = wfv1.NodeSucceeded | |||
woc.wf.Status.Nodes[retryNode.ID] = *retryNode | |||
woc = newWorkflowOperationCtx(woc.wf, controller) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
|
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.See #3862