Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Panic or error on mis-matched resource version #3949

Merged
merged 5 commits into from
Sep 14, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 4, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

See #3862

@alexec alexec added this to the v2.12 milestone Sep 4, 2020
@alexec alexec marked this pull request as ready for review September 6, 2020 17:24
@alexec alexec added type/feature Feature request P3 labels Sep 8, 2020
status:
phase: Running
startedAt: "2020-07-14T16:26:21Z"
limit: 2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" is missing

@@ -614,6 +617,7 @@ func TestDagAssessPhaseContinueOnExpandedTaskVariables(t *testing.T) {
woc := newWorkflowOperationCtx(wf, controller)

woc.operate()
woc = newWorkflowOperationCtx(woc.wf, controller)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to create a new context here? we can just use woc.operate() which will have updated wf.

@@ -835,6 +839,7 @@ func TestDagAssessPhaseContinueOnExpandedTask(t *testing.T) {
woc := newWorkflowOperationCtx(wf, controller)

woc.operate()
woc = newWorkflowOperationCtx(woc.wf, controller)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

@@ -1765,6 +1771,7 @@ func TestOnExitNonLeaf(t *testing.T) {

retryNode.Phase = wfv1.NodeSucceeded
woc.wf.Status.Nodes[retryNode.ID] = *retryNode
woc = newWorkflowOperationCtx(woc.wf, controller)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@alexec
Copy link
Contributor Author

alexec commented Sep 14, 2020

2020-09-14T19:29:03.8397834Z --- FAIL: TestArgoServerSuite (38.73s)
2020-09-14T19:29:03.8398765Z     --- FAIL: TestArgoServerSuite/TestWorkflowService (2.28s)
2020-09-14T19:29:03.8399892Z         --- FAIL: TestArgoServerSuite/TestWorkflowService/Terminate (2.00s)
2020-09-14T19:29:03.8402489Z             reporter.go:39: 
2020-09-14T19:29:03.8403200Z                 	Error Trace:	reporter.go:39
2020-09-14T19:29:03.8403645Z                 	            				chain.go:21
2020-09-14T19:29:03.8404038Z                 	            				helpers.go:33
2020-09-14T19:29:03.8404430Z                 	            				value.go:81
2020-09-14T19:29:03.8404854Z                 	            				argo_server_test.go:805
2020-09-14T19:29:03.8405261Z                 	            				suite.go:77
2020-09-14T19:29:03.8406033Z                 	Error:      	child 'message' not found in JSON object at 10
2020-09-14T19:29:03.8406853Z                 	Test:       	TestArgoServerSuite/TestWorkflowService/Terminate
2020-09-14T19:29:03.8408024Z         --- FAIL: TestArgoServerSuite/TestWorkflowService/Resubmit (0.00s)
2020-09-14T19:29:03.8408815Z             reporter.go:39: 
2020-09-14T19:29:03.8409252Z                 	Error Trace:	reporter.go:39
2020-09-14T19:29:03.8409685Z                 	            				chain.go:21
2020-09-14T19:29:03.8410203Z                 	            				response.go:585
2020-09-14T19:29:03.8410798Z                 	            				response.go:151
2020-09-14T19:29:03.8411252Z                 	            				argo_server_test.go:813
2020-09-14T19:29:03.8411653Z                 	            				suite.go:77
2020-09-14T19:29:03.8411991Z                 	Error:      	
2020-09-14T19:29:03.8412408Z                 	            	expected status equal to:
2020-09-14T19:29:03.8412789Z                 	            	 "200 OK"
2020-09-14T19:29:03.8413079Z                 	            	
2020-09-14T19:29:03.8413392Z                 	            	but got:
2020-09-14T19:29:03.8413813Z                 	            	 "500 Internal Server Error"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants