Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): use absolute URL to redirect from autocomplete list. Closes #3903 #3906

Merged
merged 2 commits into from
Aug 31, 2020
Merged

fix(ui): use absolute URL to redirect from autocomplete list. Closes #3903 #3906

merged 2 commits into from
Aug 31, 2020

Conversation

nirav24
Copy link
Contributor

@nirav24 nirav24 commented Aug 30, 2020 •
edited
Loading

Closes #3903

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nirav24 nirav24 changed the title fix[ui]: use absolute URL to redirect from autocomplete list. Closes #3903 fix(ui): use absolute URL to redirect from autocomplete list. Closes #3903 Aug 30, 2020
alexec
alexec reviewed Aug 31, 2020
View reviewed changes
ui/src/app/workflows/components/workflows-list/workflows-list.tsx Outdated
@@ -414,7 +414,7 @@ export class WorkflowsList extends BasePage<RouteComponentProps<any>, State> {
</React.Fragment>
)}
onSelect={val => {
ctx.navigation.goto(`./${val}`);
ctx.navigation.goto(`/workflows/${val}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for submitting this PR. I think, to support BASH_HREF, you need to use uiUrl("workflows/"+val?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alexec for pointing that out. I fixed in 5f97e8e

@alexec
Copy link
Contributor

alexec commented Aug 31, 2020

TestPendingRetryWorkflow is flaky.

alexec
alexec approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alexec
Copy link
Contributor

alexec commented Aug 31, 2020

No one has complained about this, so not sure it is much used, and therefore wont` backport to v2.10.

@alexec alexec merged commit b681c11 into argoproj:master Aug 31, 2020
@nirav24 nirav24 deleted the fix/autocomplete-url-redirect branch August 31, 2020 22:06
alexec pushed a commit that referenced this pull request Sep 2, 2020
@nirav24 @alexec
fix(ui): use absolute URL to redirect from autocomplete list. Closes #…
ae537cd 
…3903 (#3906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow auto-completes to wrong URL
3 participants
@nirav24 @CLAassistant @alexec