fix: Corrects CRD and Swagger types. Fixes #3578 #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Aug 18, 2020
| // +protobuf.options.(gogoproto.goproto_stringer)=false | ||
| // +k8s:openapi-gen=true | ||
| // +kubebuilder:validation:Type=object |
There was a problem hiding this comment.
this is actually not fixable, because Item can be anything, but code-generator mandates a single type only, we must choose the best/least worst type.
alexec
commented
Aug 18, 2020
| @@ -338,8 +338,9 @@ func (s ShutdownStrategy) ShouldExecute(isOnExitPod bool) bool { | |||
| } | |||
| } | |||
|
|
|||
| // +kubebuilder:validation:Type=array | |||
There was a problem hiding this comment.
kubebuilder is too limited to correctly describe this type. We must choose a best option.
alexec
commented
Aug 18, 2020
| @@ -379,7 +380,7 @@ func (p *ParallelSteps) UnmarshalJSON(value []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *ParallelSteps) MarshalJSON() ([]byte, error) { | |||
| func (p ParallelSteps) MarshalJSON() ([]byte, error) { | |||
There was a problem hiding this comment.
MarshallJSON MUST not be a pointer receiver, otherwise we cannot marshal not-pointer instances of the type.
|
Need @jessesuen to approve proto changes. |
|
Migrating to generator v0.4.0 (which would allow the |
|
@jessesuen tried out v0.4.0 and got it working, but looks like IntellI does not support |
jessesuen
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Fixes #3578