Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Failure tolerant workflow archiving and offloading. Fixes #3786 and #3837 #3787

Merged
merged 12 commits into from
Aug 28, 2020
Merged

fix(controller): Failure tolerant workflow archiving and offloading. Fixes #3786 and #3837 #3787

merged 12 commits into from
Aug 28, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Aug 14, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #3786
Fixes #3837

@alexec alexec closed this Aug 17, 2020
@alexec alexec deleted the fix-3786 branch August 21, 2020 00:41
@alexec alexec restored the fix-3786 branch August 21, 2020 00:41
@alexec alexec reopened this Aug 21, 2020
@alexec alexec linked an issue Aug 21, 2020 that may be closed by this pull request
More robust node status offloading #3837
Closed
@alexec alexec changed the title fix(controller): Failure tolerant workflow archiving. Fixes #3786 fix(controller): Failure tolerant workflow archiving. Fixes #3786 and #3837 Aug 21, 2020
@alexec
Copy link
Contributor Author

alexec commented Aug 21, 2020 •
edited
Loading

  • TestEventOnWorkflowSuccess
  • TestEventOnNodeFail

@alexec
Copy link
Contributor Author

alexec commented Aug 21, 2020

  • TestEventOnNodeFail

@alexec alexec closed this Aug 21, 2020
@alexec alexec reopened this Aug 21, 2020
@alexec alexec marked this pull request as ready for review August 21, 2020 20:08
@alexec alexec changed the title fix(controller): Failure tolerant workflow archiving. Fixes #3786 and #3837 fix(controller): Failure tolerant workflow archiving and offloading. Fixes #3786 and #3837 Aug 25, 2020
@alexec alexec merged commit 0cf7709 into argoproj:master Aug 28, 2020
@alexec alexec deleted the fix-3786 branch August 28, 2020 16:16
alexec added a commit that referenced this pull request Aug 28, 2020
@alexec
fix(controller): Failure tolerant workflow archiving and offloading. F…
ee84892 
…ixes #3786 and #3837 (#3787)
alexec added a commit to alexec/argo-workflows that referenced this pull request Nov 10, 2020
@alexec
Revert "fix(controller): Failure tolerant workflow archiving and offl…
a37b532 
…oading. Fixes argoproj#3786 and argoproj#3837 (argoproj#3787)"

This reverts commit ee84892.

Signed-off-by: Alex Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More robust node status offloading More robust workflow archiving
2 participants
@alexec @sarabala1979