Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Support deleting resubmitted workflows #3554

Merged
merged 2 commits into from
Jul 24, 2020
Merged

feat(cli): Support deleting resubmitted workflows #3554

merged 2 commits into from
Jul 24, 2020

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jul 22, 2020

Signed-off-by: terrytangyuan [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@simster7
Copy link
Member

Hey @terrytangyuan, could you add a test for this change? Take a look at https://github.com/argoproj/argo/blob/master/test/e2e/cli_test.go for examples

@terrytangyuan
Copy link
Member Author

@simster7 Thanks for the reminder! Test added.

@simster7 simster7 merged commit cdc935a into argoproj:master Jul 24, 2020
@simster7
Copy link
Member

Thanks!

@terrytangyuan terrytangyuan deleted the resubmit-delete-wf branch July 24, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants