Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: link to server auth mode docs, adds Tulip as official user #3486

Merged
merged 11 commits into from
Jul 16, 2020
Merged

fix: link to server auth mode docs, adds Tulip as official user #3486

merged 11 commits into from
Jul 16, 2020

Conversation

terev
Copy link
Contributor

@terev terev commented Jul 15, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

alexec
alexec requested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Can you please fix the errors in the codegen job?

@alexec alexec self-assigned this Jul 15, 2020
@terev terev requested a review from alexec July 15, 2020 23:04
@alexec
Copy link
Contributor

alexec commented Jul 15, 2020

Looks good.

alexec
alexec reviewed Jul 15, 2020
View reviewed changes
USERS.md Outdated Show resolved Hide resolved
@alexec alexec merged commit 69179e7 into argoproj:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terev @alexec