perf: Optimize time-based filtering on large number of workflows #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
terrytangyuan
changed the title
alexec
reviewed
Jun 29, 2020
| @@ -125,6 +125,11 @@ var ( | |||
| return !wf.Status.FinishedAt.IsZero() && wf.Status.FinishedAt.Time.Before(t) | |||
| } | |||
| } | |||
| WorkflowHappenedBetween = func(startTime time.Time, endTime time.Time) WorkflowPredicate { | |||
There was a problem hiding this comment.
Much better. Updated. Thanks!
Signed-off-by: terrytangyuan <[email protected]>
alexec
reviewed
Jul 1, 2020
| @@ -125,6 +125,11 @@ var ( | |||
| return !wf.Status.FinishedAt.IsZero() && wf.Status.FinishedAt.Time.Before(t) | |||
| } | |||
| } | |||
| WorkflowRanBetween = func(startTime time.Time, endTime time.Time) WorkflowPredicate { | |||
There was a problem hiding this comment.
interesting, I can think of other interpretation of this:
- the workflow started between times A and B - e.g. WorkflowStartedBetween
- the workflow finished between times A and. B - e.g. WorkflowFinishedBetween
- the workflow was running between the two times - i.e. start time is before B and (not finished OR finished after time A) - e.g. WorkflowRanBetween?
- the workflow was ran and finished between the two times - i.e. started after A and finished before B - e.g. WorkflowWasBetween?
There was a problem hiding this comment.
Yes. Should we discuss further on a better design in a separate issue? The original purpose of this PR is to optimize the performance of the existing functionality. We can definitely break this down and see if we can come up something more comprehensive and useful in practice.
alexec
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
WorkflowPredicatefor filtering workflows based on a time range, which brings performance gains when listing large number of workflows, especially when the first filtering condition only filtered out very small number of workflows this could be a huge speed-up.Signed-off-by: terrytangyuan [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".