Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Add examples of @latest alias for relevant commands. Fixes #3225 #3242

Merged
merged 2 commits into from
Jun 17, 2020
Merged

chore(cli): Add examples of @latest alias for relevant commands. Fixes #3225 #3242

merged 2 commits into from
Jun 17, 2020

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jun 17, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@rbreeze rbreeze changed the title chore(cli): Add examples of @latest alias for relevant commands. Fix #3225 chore(cli): Add examples of @latest alias for relevant commands. Fixes #3225 Jun 17, 2020
simster7
simster7 reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to make sure the CI runs before I approve

cmd/argo/commands/retry.go
Comment on lines +31 to +32
# Retry several workflows:
argo retry my-wf my-other-wf my-third-wf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@simster7
Copy link
Member

Looks like this needs a make lint

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

simster7
simster7 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rbreeze rbreeze merged commit 4bd33c6 into argoproj:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbreeze @simster7