fix: Support the TTLStrategy for WorkflowTemplateRef #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
reviewed
Jun 16, 2020
Comment on lines
197
to
199
| } else { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Is this necessary? The same check happens in line 189
Comment on lines
217
to
220
| ttlStrategy := wf.Spec.TTLStrategy | ||
|
|
||
| if ttlStrategy == nil && wf.Status.StoredWorkflowSpec != nil && wf.Status.StoredWorkflowSpec.TTLStrategy != nil { | ||
| ttlStrategy = wf.Status.StoredWorkflowSpec.TTLStrategy |
There was a problem hiding this comment.
Perhaps extract this to a getTTLStrategy(wf *wfv1.Workflow) function?
There was a problem hiding this comment.
workflow.Spec.GetTTLStrategy()
There was a problem hiding this comment.
I prefer a util function getTTLStrategy(wf *wfv1.Workflow) because it needs to check status and spec for getting the TTLStrategy
|
Kudos, SonarCloud Quality Gate passed!
|
simster7
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". WorkflowTemplates not respecting ttlStrategy #3227