build: Use goreman for starting locally. #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
May 21, 2020
| - run: | ||
| name: Install and start K3S v1.0.1 | ||
| command: curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.0.1 INSTALL_K3S_EXEC=--docker K3S_KUBECONFIG_MODE=644 sh - | ||
| background: true | ||
| - restore_go_cache | ||
| - install_golang | ||
| - run: |
There was a problem hiding this comment.
fix regular failing builds (due to Golang not being installed)
alexec
commented
May 21, 2020
| kubectl -n argo apply -f dist/no-db.yaml | ||
| endif | ||
| endif | ||
| kubectl -n argo apply -l app.kubernetes.io/part-of=argo --prune --force -f dist/$(DB).yaml |
There was a problem hiding this comment.
this will delete mysql if you run postgres and vice-versa, but not delete workflows
There was a problem hiding this comment.
Great, thanks for fitting my use case.
simster7
approved these changes
May 21, 2020
| kubectl -n argo apply -f dist/no-db.yaml | ||
| endif | ||
| endif | ||
| kubectl -n argo apply -l app.kubernetes.io/part-of=argo --prune --force -f dist/$(DB).yaml |
There was a problem hiding this comment.
Great, thanks for fitting my use case.
| @@ -2,6 +2,8 @@ | |||
| apiVersion: apiextensions.k8s.io/v1beta1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| labels: | |||
| app.kubernetes.io/part-of: argo | |||
|
Linked #2965 to this |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@simster7 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2965
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Changes
argo-serverandworkflow-controllerand started usinggoremansame as Argo CD, which foreground them and logs which prepend the app name:We label resources and can prune resources not needed.
This can be merged as soon as green.