Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Allow opening workflow logs in a new tab; Closes #2887 #2935

Merged
merged 1 commit into from
May 3, 2020

Conversation

changhc
Copy link
Contributor

@changhc changhc commented May 3, 2020

This is for the log button (example workflow link) in the top bar:
image

By default the current window will be redirected to the link. A new tab will be opened if ctrl is pressed when the link is clicked.

Closes #2887.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alexec alexec merged commit 20d69c7 into argoproj:master May 3, 2020
alexec pushed a commit to alexec/argo-workflows that referenced this pull request May 4, 2020
@dguendisch
Copy link

Thanks for adding this, I guess there was no other way, i.e. now way to render that button "really as a link"?
Because while Ctrl would work on Win+Linux, I guess on Mac Ctrl+Click always resolves to right button click, then again it's dependent on the browser whether it's Ctrl (or Cmd on Mac) or Shift to open in a new tab vs. new window respectively.
Wouldn't it be possible to let that thing render as a link, so that the browser knows that it is a link and the browser applies all corresponding "link behaviour"?

@changhc
Copy link
Contributor Author

changhc commented May 4, 2020

Actually yes. Initially I wanted to render <a>, which would solve the problem completely, but that involves updating the ui library. This solution is faster but also a bit hacky. I didn't notice the behaviour on Mac. I'll create a separate PR to the ui library and let's see if others think it's okay.

Thanks for your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to open workflow logs in new tab
3 participants