Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display Workflow finish time in UI #2896

Merged
merged 4 commits into from
May 5, 2020
Merged

fix: Display Workflow finish time in UI #2896

merged 4 commits into from
May 5, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Apr 29, 2020 •
edited
Loading

Fixes some changes from #2863:

  1. Sorts Workflows by FinishedAt time as previously done in workflow-list and archive-workflow-list.

  2. Adds Finished field to lists.

image

We should add more sorting options in the UI: opened #2895 for this.

@simster7 simster7 requested a review from alexec April 29, 2020 19:43
alexec
alexec reviewed Apr 29, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting needs to be done server side, as it breaks pagination?

@simster7
Copy link
Member Author

Yes, of course. I'll rework.

@simster7 simster7 linked an issue May 1, 2020 that may be closed by this pull request
Workflow list pagination by date completed #2926
Closed
@simster7 simster7 changed the title fix: Sort Workflows by finish time in UI fix: Display Workflow finish time in UI May 5, 2020
@simster7 simster7 mentioned this pull request May 5, 2020
Merged
6 tasks
@simster7 simster7 requested a review from alexec May 5, 2020 15:07
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@simster7 simster7 merged commit fe9f901 into argoproj:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow list pagination by date completed
2 participants
@simster7 @alexec