Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't error when deleting already-deleted WFs #2866

Merged
merged 2 commits into from
Apr 27, 2020
Merged

fix: Don't error when deleting already-deleted WFs #2866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7dfd2
fix: Don't error when deleting already-deleted WFs
simster7 Apr 27, 2020
369e449
fmt
simster7 Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workflow/cron/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/robfig/cron/v3"
log "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"

Expand Down Expand Up @@ -292,6 +293,10 @@ func (woc *cronWfOperationCtx) deleteOldestWorkflows(jobList []v1alpha1.Workflow
for _, wf := range jobList[workflowsToKeep:] {
err := woc.wfClient.Delete(wf.Name, &v1.DeleteOptions{})
if err != nil {
if errors.IsNotFound(err) {
log.Infof("Workflow '%s' was already deleted", wf.Name)
continue
}
return fmt.Errorf("error deleting workflow '%s': %e", wf.Name, err)
}
log.Infof("Deleted Workflow '%s' due to CronWorkflow '%s' history limit", wf.Name, woc.cronWf.Name)
Expand Down