Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Display wf.Status.Conditions in CLI #2858

Merged
merged 1 commit into from
Apr 27, 2020
Merged

chore: Display wf.Status.Conditions in CLI #2858

merged 1 commit into from
Apr 27, 2020

Conversation

simster7
Copy link
Member

Closes: #2845

Screenshots:
image
image

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
6.2% 6.2% Duplication

alexec
alexec approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval - please check fo duplication with existing code that Sonar is hinting at.

@simster7
Copy link
Member Author

The relevant code duplication can be found in cmd/argo/archive/get.go. I tried to extract the function so that they can be shared, but it was a bit more effort that it was worth now. Opened #2864 to track, this should get done around the same time as other CLI-related refactors: #1935, #2738

@simster7 simster7 merged commit e84acb5 into argoproj:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a “status.conditions” display to CLI output
2 participants
@simster7 @alexec