Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build less and therefore faster #2839

Merged
merged 21 commits into from
Apr 29, 2020
Merged

ci: Build less and therefore faster #2839

merged 21 commits into from
Apr 29, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 25, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

This came to me in a dream if you can believe it.

To start Argo, it is 2-3m quicker on CI, and much much faster locally.

  • Rather than build 2 binaries (Darwin and Linux), we just build Darwin.
  • Build a Darwin binary for the controller, so maybe we get to reuse the build cache when we build the CLI.
  • Don't run Linux containers on a Darwin.
  • Don't import the images into the K3D cluster.
  • Don't copy files around and then remove them, instead move them then put them back.
  • Don't remove the vendor directory.

Side-effects:

  • Removed the run target - start now does port forwarding AND log tailing.
  • If the controller or argo server don't start - you should know straight away.
  • We no longer need DEV_IMAGE targets except for argoexec.
  • You'll need to dismiss "Do you want the app .. to accept incoming network connections" security pop-up.

Please make sure you check out the code and run locally to verify!! I want to try and avoid teething issues.

@alexec alexec marked this pull request as ready for review April 26, 2020 04:44
@alexec alexec added this to the v2.9 milestone Apr 27, 2020
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec merged commit c05c385 into argoproj:master Apr 29, 2020
@alexec alexec deleted the build-less branch April 29, 2020 00:03
alexec added a commit that referenced this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants