Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose workflow.Spec.ServiceAccountName as global variable. See #2794 #2838

Merged
merged 1 commit into from
Apr 27, 2020
Merged

feat: expose workflow.Spec.ServiceAccountName as global variable. See #2794 #2838

merged 1 commit into from
Apr 27, 2020

Conversation

seddonm1
Copy link
Contributor

Reopening #2810

This PR exposes workflow.Spec.ServiceAccountName as global variable "workflow.serviceAccountName" similar to "workflow.namespace".

Issue: #2794

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@seddonm1 seddonm1 mentioned this pull request Apr 24, 2020
Closed
6 tasks
@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

simster7
simster7 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@simster7 simster7 merged commit 9074335 into argoproj:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seddonm1 @simster7