Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update the contributing docs #2791

Merged
merged 4 commits into from
Apr 23, 2020
Merged

docs: Update the contributing docs #2791

merged 4 commits into from
Apr 23, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 22, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec changed the title Docs works docs: Update the contributing docs Apr 22, 2020
@alexec alexec marked this pull request as ready for review April 22, 2020 23:46
@alexec alexec requested a review from edlee2121 April 22, 2020 23:46
@alexec alexec merged commit 29d39e2 into argoproj:master Apr 23, 2020
@alexec alexec deleted the docs-works branch April 23, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@edlee2121 edlee2121 Awaiting requested review from edlee2121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @sarabala1979