Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(users): Adding Habx to the users list #2781

Merged
merged 2 commits into from
Apr 30, 2020
Merged

docs(users): Adding Habx to the users list #2781

merged 2 commits into from
Apr 30, 2020

Conversation

fclairamb
Copy link
Contributor

@fclairamb fclairamb commented Apr 22, 2020 •
edited
Loading

We're are very happy with it.

We perform various tasks around it, mostly:

  • Automatic flat enrichment (adding furniture to make them look prettier)
  • Baking of 3D models of flats (using blender in a container)
  • Automatic batch processing of some 3D models of furniture and decorations

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fclairamb fclairamb changed the title Adding our company to the users list docs(users): Adding Habx to the users list Apr 22, 2020
@fclairamb
Copy link
Contributor Author

My builds aren't green because, the status check: argo-workflow's test step reports "Unauthorized".

simster7
simster7 reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fclairamb, thanks for adding Habx to our users list! Can you add Habx in its alphabetically correct order? Our list is alphabetized.

Don't worry about the CI.

alexec
alexec requested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort alpha! Welcome on board!

@clementlecorre
Copy link

It's done! @alexec 👍

@fclairamb
Copy link
Contributor Author

Great ! Thank you !

@alexec alexec self-assigned this Apr 28, 2020
@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexec alexec merged commit 9a33aa2 into argoproj:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@alexec alexec alexec approved these changes

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fclairamb @CLAassistant @clementlecorre @simster7 @alexec