Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make phase and templateRef available for unsuspend and retry selectors #2723

Merged
merged 1 commit into from
Apr 20, 2020
Merged

feat: Make phase and templateRef available for unsuspend and retry selectors #2723

merged 1 commit into from
Apr 20, 2020

Conversation

markterm
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@markterm
Copy link
Contributor Author

@simster7 Might be good for you to review? As it relates to my previous PR. Thx

@simster7 simster7 self-assigned this Apr 20, 2020
@alexec alexec requested a review from simster7 April 20, 2020 15:33
@alexec alexec changed the title Make phase and templateRef available for unsuspend and retry selectors feat: Make phase and templateRef available for unsuspend and retry selectors Apr 20, 2020
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell D 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

alexec
alexec reviewed Apr 20, 2020
View reviewed changes
workflow/util/util.go
"phase": string(node.Phase),
}
if node.TemplateRef != nil {
nodeFields["templateRef.name"] = node.TemplateRef.Name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

simster7
simster7 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As @alexec mentioned, it would be great if you could cover selectorMatchesNode with some tests

@alexec
Copy link
Contributor

alexec commented Apr 20, 2020

do the tests later please

@alexec alexec merged commit 391c0f7 into argoproj:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec left review comments

@simster7 simster7 simster7 approved these changes

Assignees

@simster7 simster7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markterm @alexec @simster7