fix: allow non path output params #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
reviewed
Apr 14, 2020
workflow/validate/validate_test.go
Outdated
| parameters: | ||
| - name: param | ||
| valueFrom: | ||
| parameter: p |
There was a problem hiding this comment.
Can we fill this in with a real parameter? Having complete workflows in our test cases makes them readily available when needed
There was a problem hiding this comment.
Fixed it. Can you review it again?
|
Kudos, SonarCloud Quality Gate passed!
|
simster7
approved these changes
Apr 21, 2020
simster7
pushed a commit
that referenced
this pull request
Apr 27, 2020
|
Back-ported to 2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
I found k8s-jobs.yaml in the examples doesn't work with the k8sapi executor because the validation mistakenly validates output parameters even without interacting with file systems. I changed it to allow using output parameters other than
pathtype withoutemptyDir.