Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report metric emission errors via Conditions #2676

Merged
merged 5 commits into from
Apr 14, 2020

Conversation

simster7
Copy link
Member

Fixes #2675

image

@simster7 simster7 requested a review from alexec April 13, 2020 21:29
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@simster7 simster7 merged commit 9f95e23 into argoproj:master Apr 14, 2020
@simster7
Copy link
Member Author

Back-ported to 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance reporting of metric emssision errors
3 participants