Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support minimal mysql version 5.7.8. Fixes #2625 #2633

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Apr 8, 2020

Fixes: #2625

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #2633 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2633      +/-   ##
==========================================
+ Coverage   11.14%   11.16%   +0.02%     
==========================================
  Files          83       83              
  Lines       32652    32646       -6     
==========================================
+ Hits         3640     3646       +6     
+ Misses      28514    28502      -12     
  Partials      498      498              
Impacted Files Coverage Δ
persist/sqldb/migrate.go 0.00% <0.00%> (ø)
pkg/apis/workflow/v1alpha1/workflow_types.go 10.93% <0.00%> (+0.02%) ⬆️
workflow/controller/dag.go 50.93% <0.00%> (+0.31%) ⬆️
workflow/controller/operator.go 61.30% <0.00%> (+0.31%) ⬆️
workflow/controller/steps.go 65.35% <0.00%> (+0.46%) ⬆️
workflow/templateresolution/context.go 69.46% <0.00%> (+4.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8facace...5e4f76c. Read the comment docs.

@alexec alexec merged commit 212c6d7 into argoproj:master Apr 8, 2020
@whynowy whynowy deleted the mysql5_6 branch April 8, 2020 16:45
@simster7
Copy link
Member

Back-ported to 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL 5.6 is not supported as an workflow archive
3 participants