Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes empty/missing CM. Fixes #2285 #2562

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 1, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@alexec alexec requested a review from sarabala1979 April 1, 2020 21:52
@alexec alexec linked an issue Apr 1, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #2562 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
+ Coverage   11.21%   11.23%   +0.01%     
==========================================
  Files          75       75              
  Lines       31838    31840       +2     
==========================================
+ Hits         3571     3577       +6     
+ Misses      27783    27778       -5     
- Partials      484      485       +1
Impacted Files Coverage Δ
config/config.go 33.33% <ø> (ø) ⬆️
config/controller.go 23.94% <33.33%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49801e3...b30af0d. Read the comment docs.

@alexec alexec marked this pull request as ready for review April 2, 2020 15:06
@alexec alexec merged commit ffbb3b8 into argoproj:master Apr 2, 2020
@alexec alexec deleted the fix-cm branch April 2, 2020 15:06
alexec added a commit that referenced this pull request Apr 2, 2020
@alexec alexec mentioned this pull request Apr 6, 2020
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo server should start without configmap
2 participants