Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase client gRPC max size to match server. Fixes #2513 #2514

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

markterm
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@markterm markterm force-pushed the increase-client-grpc-max-size branch from 1c33ce4 to 1ebc06a Compare March 25, 2020 14:46
@alexec alexec changed the title Increase client gRPC max size to match server. Fixes #2513 fix: Increase client gRPC max size to match server. Fixes #2513 Mar 25, 2020
@alexec alexec linked an issue Mar 25, 2020 that may be closed by this pull request
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@33cd4f2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2514   +/-   ##
=========================================
  Coverage          ?   11.39%           
=========================================
  Files             ?       75           
  Lines             ?    31125           
  Branches          ?        0           
=========================================
  Hits              ?     3547           
  Misses            ?    27102           
  Partials          ?      476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cd4f2...1ebc06a. Read the comment docs.

@alexec alexec merged commit 661d1b6 into argoproj:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client max gRPC size does not match server
2 participants