Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix template scope tests #2498

Merged
merged 2 commits into from
Mar 25, 2020
Merged

fix: fix template scope tests #2498

merged 2 commits into from
Mar 25, 2020

Conversation

dtaniwaki
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

I mistakenly modified the generated code in #2417 and the code has been overwritten in #2448
. I added the default namespace into workflow manifests because fake clients cannot handle an empty namespace correctly.

@dtaniwaki dtaniwaki changed the title Fix: fix template scope tests fix: fix template scope tests Mar 23, 2020
@dtaniwaki
Copy link
Member Author

I also removed SkipNow added in #2433. Please just tell me if the tests are still flakey.

@dtaniwaki dtaniwaki requested a review from alexec March 23, 2020 12:08
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@33cd4f2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2498   +/-   ##
=========================================
  Coverage          ?   11.44%           
=========================================
  Files             ?       74           
  Lines             ?    31114           
  Branches          ?        0           
=========================================
  Hits              ?     3562           
  Misses            ?    27079           
  Partials          ?      473

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cd4f2...62ac451. Read the comment docs.

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give it a go.

@alexec alexec merged commit b1ad163 into argoproj:master Mar 25, 2020
alexec added a commit that referenced this pull request Mar 26, 2020
alexec added a commit that referenced this pull request Mar 26, 2020
@dtaniwaki dtaniwaki deleted the fix-template-scope-tests branch March 27, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants