Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Rearrange the order of chunk size argument in list command. Closes #2420 #2485

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

changhc
Copy link
Contributor

@changhc changhc commented Mar 19, 2020

This PR ensures that the returned list of workflows has a max length of chunkSize. Previously we apply chunkSize before all the filtering such that the returned list may have fewer items than expected.

Closes #2420.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@changhc changhc changed the title fix(cli): Rearrange the order of chunk size argument in list command fix(cli): Rearrange the order of chunk size argument in list command. Closes #2420 Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1350882). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2485   +/-   ##
=========================================
  Coverage          ?   13.13%           
=========================================
  Files             ?       71           
  Lines             ?    25123           
  Branches          ?        0           
=========================================
  Hits              ?     3301           
  Misses            ?    21404           
  Partials          ?      418
Impacted Files Coverage Δ
cmd/argo/commands/list.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1350882...dba7f25. Read the comment docs.

@alexec alexec merged commit 96c80e3 into argoproj:master Mar 20, 2020
@alexec
Copy link
Contributor

alexec commented Mar 20, 2020

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.6.1: argo list --chunk-size truncation should apply after other filters
2 participants