Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat: Add support for arm64 platform (#2364)" #2482

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Mar 19, 2020

This reverts commit c724c7c. The commit breaks workflow-controller and argo-server with error:

standard_init_linux.go:190: exec user process caused "exec format error"

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

@alexec alexec changed the title Revert "feat: Add support for arm64 platform (#2364)" chore: Revert "feat: Add support for arm64 platform (#2364)" Mar 19, 2020
@whynowy whynowy changed the title chore: Revert "feat: Add support for arm64 platform (#2364)" fix: Revert "feat: Add support for arm64 platform (#2364)" Mar 19, 2020
@whynowy whynowy changed the title fix: Revert "feat: Add support for arm64 platform (#2364)" chore: Revert "feat: Add support for arm64 platform (#2364)" Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@735d25e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2482   +/-   ##
=========================================
  Coverage          ?   11.24%           
=========================================
  Files             ?       73           
  Lines             ?    30902           
  Branches          ?        0           
=========================================
  Hits              ?     3476           
  Misses            ?    26956           
  Partials          ?      470

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735d25e...bd8c0ec. Read the comment docs.

@whynowy whynowy merged commit 063d9bc into argoproj:master Mar 19, 2020
@whynowy whynowy deleted the revert_change branch March 19, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants