Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build image with SHA tag when a git tag is not available #2479

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

simster7
Copy link
Member

When building an image from a detached head there is no git tag and the Makefile fails. In that case use the git sha hash.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

When building an image from a detached head there is no git tag and the Makefile fails. In that case use the git sha hash.
@simster7 simster7 merged commit 735d25e into master Mar 19, 2020
@simster7 simster7 deleted the make-tag branch March 19, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants