Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ParallelSteps swagger.json #2459

Merged
merged 10 commits into from
Mar 18, 2020

Conversation

crenshaw-dev
Copy link
Contributor

@crenshaw-dev crenshaw-dev commented Mar 16, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

This hacks the incorrectly-inferred object type for ParallelSteps back to an array. Closes #2454. Will also fix argoproj-labs/argo-client-java#1 downstream.

jq converts a bunch of unicode-encoded characters to ascii. As far as I can tell, that should have no negative effects.

I also added some go get lines for dependencies which were missing on my machine.

@crenshaw-dev crenshaw-dev changed the title fix: ParallelSteps swagger.json; closes #2454 fix: ParallelSteps swagger.json Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@14478bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2459   +/-   ##
=========================================
  Coverage          ?   11.26%           
=========================================
  Files             ?       72           
  Lines             ?    30767           
  Branches          ?        0           
=========================================
  Hits              ?     3465           
  Misses            ?    26839           
  Partials          ?      463

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14478bc...4acb79d. Read the comment docs.

go.mod Outdated Show resolved Hide resolved
hack/update-mocks.sh Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@alexec alexec added this to the v2.7 milestone Mar 18, 2020
@alexec alexec merged commit 10a0789 into argoproj:master Mar 18, 2020
@crenshaw-dev crenshaw-dev deleted the fix-parallelsteps-swagger branch April 3, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swagger.json treats ParallelSteps as an object instead of an array JsonSyntaxException for getWorkflow
2 participants