chore: Remove extreneous config from quick-start

[simster7]

Minor

[alexec]

You've removed them from both quick-start and tests? I think the latter are needed.

[simster7]

@alexec I simply removed them from quick-start and ran make manifests. Seems like make manifests also updates tests/:

make manifests
# GIT_TAG=, GIT_BRANCH=man, GIT_TREE_STATE=dirty, VERSION=man, DEV_IMAGE=true
...
# Create Postgres e2e manifests
kustomize build test/e2e/manifests/postgres | ./hack/auto-gen-msg.sh > test/e2e/manifests/postgres.yaml
# Create MySQL e2e manifests
kustomize build test/e2e/manifests/mysql | ./hack/auto-gen-msg.sh > test/e2e/manifests/mysql.yaml
# Create no DB e2e manifests
kustomize build test/e2e/manifests/no-db | ./hack/auto-gen-msg.sh > test/e2e/manifests/no-db.yaml

I also ran the relevant tests to make sure they worked before I opened this PR.

[alexec]

I also ran the relevant tests to make sure they worked before I opened this PR.

Do you want to @mention the author and find out?

[simster7]

@jamhed Are these configs necessary for the tests in #2385?

[codecov]

Codecov Report

Merging #2457 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2457   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          72       72           
  Lines       28892    28892           
=======================================
  Hits         3378     3378           
  Misses      25070    25070           
  Partials      444      444

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5346609...c06fb63. Read the comment docs.

[jamhed]

@simster7, yes, they are necessary, without limits argo watcher pod can't be submitted if we have resourcequota enabled for namespace, I copied values from existing examples.

[simster7]

Alright, thanks. Will close this for now.

[simster7]

I'm reconsidering this... @alexec currently we use the same set of templates for quick-start and for testing, but this change only needs to be in our testing manifests. I don't think that this should be in our quick-start manifests because it introduces behavior that is not desired by default.

What do you think about decoupling the quick-start manifests and the testing manifests? If we do so, we can remove this executor config from the quick-start manifests and keep it in the testing manifests.

[alexec]

I'm reconsidering this... @alexec currently we use the same set of templates for quick-start and for testing, but this change only needs to be in our testing manifests. I don't think that this should be in our quick-start manifests because it introduces behavior that is not desired by default.

What do you think about decoupling the quick-start manifests and the testing manifests? If we do so, we can remove this executor config from the quick-start manifests and keep it in the testing manifests.

I was keen to keep them closely related. Otherwise, we never test the manifests (both install.yaml and quick-starts) are correct. I'd prefer we only kustomize the test manifests and there are scripts for that.

[alexec]

This will be fixed by #2464.

[simster7]

Closing