fix(archive): Fix edge-cast error for archiving. Fixes #2427 #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alexec
commented
Mar 13, 2020
| // We assume that we're much more likely to be inserting rows that updating them, so we try and insert, | ||
| // and if that fails, then we update. | ||
| // There is no check for race condition here, last writer wins. | ||
| _, err := sess. |
There was a problem hiding this comment.
we take a different, alternative approach - delete any records from the archive table (which will cascade to labels) and then just insert the archive record and labels
Codecov Report
@@ Coverage Diff @@
## master #2434 +/- ##
=========================================
Coverage ? 13.15%
=========================================
Files ? 71
Lines ? 25230
Branches ? 0
=========================================
Hits ? 3318
Misses ? 21475
Partials ? 437
Continue to review full report at Codecov.
|
whynowy
reviewed
Mar 13, 2020
| // We assume that we're much more likely to be inserting rows that updating them, so we try and insert, | ||
| // and if that fails, then we update. | ||
| // There is no check for race condition here, last writer wins. | ||
| _, err := sess. |
whynowy
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".