-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Example showing how to use default settings for workflow spec. Related to ##2388 #2411
Conversation
@JohanWork would you like to check this out? |
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
=======================================
Coverage 13.13% 13.13%
=======================================
Files 72 72
Lines 25084 25084
=======================================
Hits 3294 3294
Misses 21375 21375
Partials 415 415 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some comments.
docs/default-workflow-specs.md
Outdated
passwordSecret: | ||
name: argo-postgres-config | ||
key: password | ||
workflowDefaults: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an example config map in the docs folder. Could you put your example here please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if I understand exactly what you want me to add so please give feedback on the changes of the example of the config map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you example is fine, but should be in docs/workflow-controller-configmap.yaml
Co-Authored-By: JohanWork <[email protected]>
Co-Authored-By: JohanWork <[email protected]>
There seams to be some issues in terms of how the value get set. I did some extra tests and the following is the updated wf:
I don't get why there is spacing in "Ttl Strategy: " and "Seconds After Completion: 10". Is this an issue @alexec |
Great stuff -- thank you!! |
This PR includes an example on how to use the default workflow specs in order to allow users set default specs for workflows. The defaults will only be used if the spec is not set.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.