Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update CONTRIBUTING.md with argo auth token command fix. #2410

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

NikeNano
Copy link
Contributor

@NikeNano NikeNano commented Mar 11, 2020

The current suggested way to get the auth token for argo when deployed don't seam to work. This PR contains a fix where:

./dist/argo auth token

is suggested to replace

./dist/argo token

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

Update how to get the token. The currently described way don't seem to work.
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #2410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2410   +/-   ##
=======================================
  Coverage   13.13%   13.13%           
=======================================
  Files          72       72           
  Lines       25084    25084           
=======================================
  Hits         3294     3294           
  Misses      21375    21375           
  Partials      415      415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19a398...f89536a. Read the comment docs.

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@alexec alexec changed the title Update CONTRIBUTING.md with argo auth token command fix. docs: Update CONTRIBUTING.md with argo auth token command fix. Mar 11, 2020
@alexec alexec merged commit 20d6e27 into argoproj:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants