fix(ui): Provide a link to archived logs. Fixes #2300 #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
changed the title
alexec
moved this from In progress
to Waiting for review or in review
in Argo Workflows OSS Kanban Board
alexec
commented
Feb 24, 2020
| public getArtifactDownloadUrl(workflow: Workflow, nodeId: string, artifactName: string, archived: boolean) { | ||
| return archived | ||
| ? `artifacts-by-uid/${workflow.metadata.uid}/${nodeId}/${encodeURIComponent(artifactName)}?Authorization=${localStorage.getItem('token')}` |
There was a problem hiding this comment.
this is dead code and should have been deleted a while ago
Codecov Report
@@ Coverage Diff @@
## master #2301 +/- ##
=========================================
Coverage ? 11.42%
=========================================
Files ? 71
Lines ? 27899
Branches ? 0
=========================================
Hits ? 3187
Misses ? 24307
Partials ? 405Continue to review full report at Codecov.
|
simster7
approved these changes
Feb 25, 2020
ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
Outdated
Show resolved
Hide resolved
Argo Workflows OSS Kanban Board
automation
moved this from Waiting for review or in review
to Reviewer approved
Feb 25, 2020
…logs-viewer.tsx Co-Authored-By: Simon Behar <[email protected]>
…rgoproj#2304) * fix(controller): Get correct Step or DAG name * Add functional test * Increase wait time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Fixes #2300.
Not quite a fix - but I think it will be good enough.
Needs back-porting to v2.5.