fix: Start Argo server with out Configmap #2285 #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarabala1979
commented
Feb 21, 2020
| @@ -9,7 +9,7 @@ | |||
| "info": { | |||
| "description": "Argo Server", | |||
| "title": "Argo Server", | |||
| "version": "latest" | |||
| "version": "issue2285" | |||
There was a problem hiding this comment.
do we need to update back latest?
sarabala1979
commented
Feb 21, 2020
| @@ -5516,31 +5516,5 @@ | |||
| } | |||
| } | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
I am not sure what caused these changes.
There was a problem hiding this comment.
just check out from master to fix
Codecov Report
@@ Coverage Diff @@
## master #2293 +/- ##
=======================================
Coverage 11.41% 11.41%
=======================================
Files 71 71
Lines 27899 27899
=======================================
Hits 3185 3185
Misses 24310 24310
Partials 404 404Continue to review full report at Codecov.
|
alexec
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Argo server should start without configmap #2285