feat: Support workflow level poddisruptionbudge for workflow pods #1728 #2286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2286 +/- ##
=========================================
Coverage ? 13.36%
=========================================
Files ? 70
Lines ? 24266
Branches ? 0
=========================================
Hits ? 3244
Misses ? 20613
Partials ? 409
Continue to review full report at Codecov.
|
Co-Authored-By: Bot from GolangCI <[email protected]>
Co-Authored-By: Bot from GolangCI <[email protected]>
Co-Authored-By: Bot from GolangCI <[email protected]>
| return nil | ||
| } | ||
|
|
||
| func (woc *wfOperationCtx) deletePDBResource() error { |
There was a problem hiding this comment.
I don't think you should delete the PDB it here. It'll just get deleted when the workflow gets deleted due to the ownership reference.
There was a problem hiding this comment.
I think PDB doesn't hold any workflow related information to keep for until workflow delete. This is like a DB transaction. It prevents the pod deletion during workflow running. we should delete PDB resource, once the workflow execution was done. This will optimize the etcd size and performance.
There was a problem hiding this comment.
I don't feel strongly about this. @jessesuen
There was a problem hiding this comment.
PDB does not look bit in size to me.
There was a problem hiding this comment.
Are you saying we cannot delete pods in there is a matching PDB?
There was a problem hiding this comment.
As discussed, we already delete resources on completion to keep things tidy, reduce etcd usage etc.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Adding Pod Disruption budget for each workflow run by argo controller so that Pod/Step does not gets deleted during autoscaling event #1728