Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sequence): broken in 2.5. Fixes #2248 #2263

Merged
merged 2 commits into from
Feb 22, 2020

Conversation

markterm
Copy link
Contributor

@markterm markterm commented Feb 19, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2248

@alexec alexec changed the title fix(sequence) broken in 2.5 #2248 fix(sequence): broken in 2.5. Fixes #2248 Feb 19, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint and test errors and we can look to merge for v2.6.

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #2263 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   11.69%   11.69%   +<.01%     
==========================================
  Files          52       52              
  Lines       26353    26353              
==========================================
+ Hits         3081     3083       +2     
+ Misses      22877    22874       -3     
- Partials      395      396       +1
Impacted Files Coverage Δ
workflow/controller/operator.go 59.11% <100%> (ø) ⬆️
workflow/controller/steps.go 62.4% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d8b5d...73f1c9a. Read the comment docs.

@alexec alexec merged commit cdbc619 into argoproj:master Feb 22, 2020
@alexec
Copy link
Contributor

alexec commented Feb 22, 2020

This is currently targeted for v2.6 (end of Feb) do you NEED it sooner?

@salanki
Copy link
Contributor

salanki commented Feb 22, 2020

Thank you for this fix and adding the test. From my end (the reporter) waiting until 2.6 is no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence broken in 2.5-rc10
4 participants