Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore bookmark events for restart. Fixes #2249 #2253

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 18, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2249 (maybe it fixes it - maybe not).

This can be merged as soon as builds are green and should be back-ported to v2.5.

@alexec alexec added this to the v2.5 milestone Feb 18, 2020
@alexec alexec marked this pull request as ready for review February 18, 2020 16:39
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #2253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2253   +/-   ##
=======================================
  Coverage   11.35%   11.35%           
=======================================
  Files          71       71           
  Lines       27979    27979           
=======================================
  Hits         3178     3178           
  Misses      24396    24396           
  Partials      405      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d88374...2f73779. Read the comment docs.

@alexec alexec merged commit 8c97689 into argoproj:master Feb 18, 2020
@alexec alexec deleted the ig-bmark branch February 18, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod argo-server keeps restarting on GCP
2 participants