Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Migrate argo logs to use API client. See #2116 #2177

Merged
merged 33 commits into from
Feb 25, 2020
Merged

chore(cli): Migrate argo logs to use API client. See #2116 #2177

merged 33 commits into from
Feb 25, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 5, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Please merge this as soon as builds are green and it is approved.

@alexec alexec added this to the v2.6 milestone Feb 5, 2020
@alexec alexec added this to In progress in Argo Workflows OSS Kanban Board via automation Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0594ddd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2177   +/-   ##
=========================================
  Coverage          ?   11.57%           
=========================================
  Files             ?       71           
  Lines             ?    27596           
  Branches          ?        0           
=========================================
  Hits              ?     3193           
  Misses            ?    23998           
  Partials          ?      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0594ddd...0ec7417. Read the comment docs.

golangcibot
golangcibot reviewed Feb 6, 2020
View reviewed changes
server/workflow/workflow_server.go Outdated Show resolved Hide resolved
cmd/argo/commands/logs.go Outdated Show resolved Hide resolved
@alexec alexec added the backlog label Feb 6, 2020
@alexec alexec removed this from the v2.6 milestone Feb 6, 2020
@alexec alexec removed this from In progress in Argo Workflows OSS Kanban Board Feb 6, 2020
@alexec alexec linked an issue Feb 6, 2020 that may be closed by this pull request
Migrate CLI workflow commands to use apiclient.Client #2116
Closed
15 tasks
alexec
alexec commented Feb 6, 2020
View reviewed changes
cmd/argo/commands/logs.go
@@ -1,517 +1,110 @@
package commands
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is basically a re-write, so I'd review the new file

alexec
alexec commented Feb 6, 2020
View reviewed changes
cmd/argo/commands/root.go Outdated Show resolved Hide resolved
alexec
alexec commented Feb 6, 2020
View reviewed changes
pkg/apiclient/workflow/workflow.proto
@@ -87,6 +87,7 @@ message WorkflowWatchEvent {

message LogEntry {
string content = 1;
string podName = 2;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this for printing

alexec
alexec commented Feb 6, 2020
View reviewed changes
test/e2e/cli_test.go Outdated Show resolved Hide resolved
alexec
alexec commented Feb 6, 2020
View reviewed changes
test/e2e/fixtures/e2e_suite.go Outdated Show resolved Hide resolved
alexec
alexec commented Feb 6, 2020
View reviewed changes
test/e2e/fixtures/e2e_suite.go Outdated Show resolved Hide resolved
alexec
alexec commented Feb 6, 2020
View reviewed changes
test/e2e/fixtures/e2e_suite.go Outdated Show resolved Hide resolved
@alexec alexec added this to the v2.6 milestone Feb 11, 2020
@alexec alexec added this to In progress in Argo Workflows OSS Kanban Board via automation Feb 11, 2020
@alexec alexec moved this from In progress to Waiting for review or in review in Argo Workflows OSS Kanban Board Feb 11, 2020
@alexec alexec modified the milestones: v2.6, Backlog Feb 19, 2020
@alexec alexec removed the backlog label Feb 19, 2020
@alexec alexec mentioned this pull request Feb 20, 2020
Closed
15 tasks
@alexec alexec changed the title chore: Migrate argo logs to use API client. See #2116 chore(cli): Migrate argo logs to use API client. See #2116 Feb 20, 2020
golangcibot
golangcibot reviewed Feb 22, 2020
View reviewed changes
pkg/apiclient/logs-intermediary.go Outdated Show resolved Hide resolved
pkg/apiclient/logs-intermediary.go Outdated Show resolved Hide resolved
pkg/apiclient/logs-intermediary.go Show resolved Hide resolved
@sarabala1979
Copy link
Member

argo logs -f <wfname> is ends without showing full log. But argo logs -f <wfname> shows full log once wf is done.
image

sarabala1979
sarabala1979 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have updated the image argo log -f is not showing full log when wf is running.

Argo Workflows OSS Kanban Board automation moved this from Waiting for review or in review to Reviewer approved Feb 25, 2020
@alexec alexec merged commit e49dd8c into argoproj:master Feb 25, 2020
Argo Workflows OSS Kanban Board automation moved this from Reviewer approved to Done Feb 25, 2020
@alexec alexec deleted the cli-logs branch February 25, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
No open projects
Argo Workflows OSS Kanban Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CLI workflow commands to use apiclient.Client
3 participants
@alexec @sarabala1979 @golangcibot