feat(ui): Use cookies in the UI. Closes #1949 #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
======================================
Coverage 8.78% 8.78%
======================================
Files 61 61
Lines 34584 34584
======================================
Hits 3037 3037
Misses 31156 31156
Partials 391 391Continue to review full report at Codecov.
|
alexec
commented
Jan 25, 2020
| @@ -339,6 +339,8 @@ up: | |||
| kubectl -n argo scale deployment/argo-server --replicas 1 | |||
| # Wait for pods to be ready | |||
| kubectl -n argo wait --for=condition=Ready pod --all -l app --timeout 2m | |||
| # Token | |||
| kubectl -n argo get `kubectl -n argo get secret -o name | grep argo-server` -o jsonpath='{.data.token}' | base64 -d | |||
There was a problem hiding this comment.
I want to know what the login token is!
There was a problem hiding this comment.
Would it be a security concern that the secret gets sent to stdout?
simster7
approved these changes
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Closes #1949
This PR allows you to authenticate using either the Authorization header, or a cookie. This means we can download artifacts without have the token in the URL, which is not secure.
Basically, if you are using the API you should have
Authorization: Bearer ..., if you are the UI should should haveCookie: authorization=....