ci: Run using our own cowsay image #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
======================================
Coverage 8.78% 8.78%
======================================
Files 61 61
Lines 34575 34575
======================================
Hits 3036 3036
Misses 31148 31148
Partials 391 391Continue to review full report at Codecov.
|
alexec
commented
Jan 24, 2020
alexec
commented
Jan 24, 2020
| command: | | ||
| docker pull golang:1.11.5 | ||
| docker pull minio/minio:RELEASE.2019-12-17T23-16-33Z | ||
| docker pull docker/whalesay:latest |
There was a problem hiding this comment.
This image has started was causing ErrImagePull and EOF errors.
alexec
commented
Jan 24, 2020
| @@ -84,12 +84,11 @@ else | |||
| endif | |||
| touch ui/dist/app | |||
|
|
|||
| .PHONY: staticfiles | |||
| staticfiles: | |||
| $(HOME)/go/bin/staticfiles: | |||
There was a problem hiding this comment.
@dtaniwaki FYI - I've changed this as it was always running with your change.
alexec
commented
Jan 24, 2020
| @@ -266,6 +269,24 @@ else | |||
| kubectl -n argo apply -f dist/mysql.yaml | |||
| endif | |||
|
|
|||
| .PHONY: test-images | |||
| test-images: dist/cowsay-v1 dist/bitnami-kubectl-1.15.3-ol-7-r165 dist/python-alpine3.6 | |||
There was a problem hiding this comment.
we build or pull the images we need for our tests prior to running tests
alexec
commented
Jan 24, 2020
alexec
commented
Jan 24, 2020
alexec
commented
Jan 24, 2020
|
Passes tests! |
sarabala1979
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".