Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix template scope #1836

Merged
merged 2 commits into from
Dec 19, 2019
Merged

fix: Fix template scope #1836

merged 2 commits into from
Dec 19, 2019

Conversation

dtaniwaki
Copy link
Member

TemplateScope should be a based template context from which a template resolution starts.

This fix is necessary to make the workflow detail view work with workflow templates without steps: e.g. examples/workflow-template/hello-world.yml

@sarabala1979 sarabala1979 changed the title Fix template scope fix: Fix template scope Dec 16, 2019
@@ -1203,6 +1203,9 @@ func (woc *wfOperationCtx) executeTemplate(nodeName string, orgTmpl wfv1.Templat
return node, ErrDeadlineExceeded
}

// Set templateScope from which the template resolution starts.
templateScope := tmplCtx.GetCurrentTemplateBase().GetTemplateScope()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

@alexec alexec merged commit 4825696 into argoproj:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants