Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: # 1328 argo submit --wait and argo wait quits while workflow is running #1347

Merged
merged 11 commits into from
May 7, 2019
Merged

Fix: # 1328 argo submit --wait and argo wait quits while workflow is running #1347

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00f08b1
CheckandEstimate implementation
sarabala1979 Apr 4, 2019
e7ac42a
fixed variable rename
sarabala1979 Apr 4, 2019
d956bfc
fixed gofmt
sarabala1979 Apr 5, 2019
be9b3b5
fixed feedbacks
sarabala1979 Apr 5, 2019
0d15503
merge
sarabala1979 Apr 9, 2019
d967df3
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Apr 9, 2019
4c9b645
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Apr 10, 2019
c40cc5f
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Apr 11, 2019
51e2d5f
Merge branch 'master' of https://github.com/argoproj/argo
sarabala1979 Apr 26, 2019
5202711
Fixed argo submit --wait and argo wait quits while workflow is running
sarabala1979 Apr 29, 2019
c9ddd50
fixed Style
sarabala1979 Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed argo submit --wait and argo wait quits while workflow is running
  • Loading branch information
@sarabala1979
sarabala1979 committed Apr 29, 2019
commit 5202711c1f69fe203b0685c060e1a66f195184b0
10 changes: 7 additions & 3 deletions cmd/argo/commands/wait.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,13 @@ func waitOnOne(workflowName string, ignoreNotFound, quiet bool) {
watchIf, err := wfClient.Watch(opts)
errors.CheckError(err)
defer watchIf.Stop()
for next := range watchIf.ResultChan() {
wf, ok := next.Object.(*wfv1.Workflow)
if !ok {
for{
next := <-watchIf.ResultChan()
wf, _ := next.Object.(*wfv1.Workflow)
if wf == nil {
watchIf.Stop()
watchIf, err = wfClient.Watch(opts)
errors.CheckError(err)
continue
}
if !wf.Status.FinishedAt.IsZero() {
Expand Down