fix(ui): display Bitbucket Server event source icon in event flow. Fixes #13386 #13387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in the Argo event flow UI. Signed-off-by: sh.yoon <[email protected]>
shyoon-devops
changed the title
shyoon-devops
changed the title
agilgur5
changed the title
agilgur5
changed the title
agilgur5
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks for tracking this down and fixing this! This looks good to me, but I haven't worked with the Event Flow UI, so I'll let someone else double check. EDIT: asked for a second review on the contributors channel
agilgur5
changed the title
|
Sure! Thanks for your review and lgtm :) |
agilgur5
pushed a commit
that referenced
this pull request
Jul 30, 2024
#13386 (#13387) Signed-off-by: sh.yoon <[email protected]> (cherry picked from commit c16c5e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13386
References
References argoproj/argo-events#1927
Motivation
Add support for displaying Bitbucket Server event source icon in the Argo event flow UI.
Modifications
Added icon support for Bitbucket Server event source.
Verification