Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): chown regression for make codegen #13375

Merged
merged 2 commits into from
Jul 22, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(devcontainer): regression in make codegen
#13348 removed a
recursive flag from chown. I believe this is because this is slow on
poorly performing filesystems.

This breaks codegen with
```
fatal: could not create leading directories of
'/home/vscode/go/src/github.com/gogo/protobuf': Permission denied
```

This is a smarter recursive chown which fixes the issue for me.

Signed-off-by: Alan Clucas <[email protected]>
  • Loading branch information
Joibel committed Jul 22, 2024
commit da31e1f1fad841810c6215137a7f186062647fb9
1 change: 1 addition & 0 deletions .devcontainer/pre-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ sudo apt install -y protobuf-compiler

# Make sure go path is owned by vscode
sudo chown vscode:vscode /home/vscode/go || true
sudo chown -R vscode:vscode /home/vscode/go/src || true
agilgur5 marked this conversation as resolved.
Show resolved Hide resolved

# download dependencies and do first-pass compile
CI=1 kit pre-up
Expand Down
Loading