fix(build): slightly optimize UI tasks in kit tasks.yaml
#13350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove dependency on server
- while the UI needs the server to connect to the API, it can start and run in parallel
- it also has some small functionality independently of the Server; it'll just error on API requests
- in particular, when I was working on the Server and UI simultaneously, any Server change would cause the whole UI task to restart, even if I did not change the UI
- this was pretty slow and inefficient as such, so remove the dep
- remove unncessary `mutex: download`
- the two dep installations can run concurrently, they're in totally separate directories and use different tools (go vs yarn)
Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
area/contributing
Joibel
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
while the UI needs the server to connect to the API, it can start and run in parallel
in particular, when I was working on the Server and UI simultaneously (e.g. fix(server): don't return
undefinedSA NS #13347), any Server change would cause the whole UI task to restart, even if I did not change the UIModifications
uitask's dependency onservertaskmutex: downloadkitwithtask#11928 (comment) as wellVerification