Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use templateScope var instead of repeatedly retrieving it from function #13345

Merged
merged 1 commit into from
Jul 16, 2024
Merged

refactor: use templateScope var instead of repeatedly retrieving it from function #13345

merged 1 commit into from
Jul 16, 2024

Conversation

qingfeng777
Copy link
Contributor

@qingfeng777 qingfeng777 commented Jul 15, 2024 •
edited by agilgur5
Loading

Motivation

For better code readability

Modifications

Use templateScope instead of repeatedly retrieving it from the function.

Verification

run locally

@agilgur5 agilgur5 changed the title refactor: use templateScope instead of repeatedly retrieving it from the function. refactor: use templateScope var instead of repeatedly retrieving it from the function. Jul 15, 2024
@agilgur5 agilgur5 changed the title refactor: use templateScope var instead of repeatedly retrieving it from the function. refactor: use templateScope var instead of repeatedly retrieving it from function Jul 15, 2024
@agilgur5 agilgur5 added the area/controller Controller issues, panics label Jul 15, 2024
agilgur5
agilgur5 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, I don't think these will ever be different. cc @Joibel who wrote the recursion detection code

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2024
Joibel
Joibel approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The recursion code was mostly a resurrected stale PR, so not really mine either.

@Joibel Joibel merged commit 61f3fd4 into argoproj:main Jul 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joibel Joibel Joibel approved these changes

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
area/controller Controller issues, panics lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qingfeng777 @Joibel @agilgur5