fix: Only cleanup agent pod if exists. Fixes #12659 #13294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oninowang <[email protected]>
Signed-off-by: jswxstw <[email protected]>
agilgur5
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Follow-up to #12679 (comment), so LGTM.
Thanks for fixing the issue and finding the right function to check!
agilgur5
pushed a commit
that referenced
this pull request
Jul 25, 2024
- merge conflicts with tests removed in backport by agilgur5 Signed-off-by: oninowang <[email protected]> Signed-off-by: jswxstw <[email protected]> Co-authored-by: jswxstw <[email protected]> Co-authored-by: agilgur5 <[email protected]> (cherry picked from commit 825aacf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #12659
Modifications
Agent pod will only be created when taskset nodes exist, so do not delete it if it does not exist.
Verification
local test and updated UT