Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor copy-edits to releases page #13134

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented Jun 2, 2024

Follow-up to #13132 and #11934

Motivation

  • did a full style guide audit of this page too, similar to my previous PRs, but there wasn't too much to change here
    • hoping to get through all the docs pages eventually

Modifications

  • remove duplicated note about breaking changes being listed in the upgrading guide

    • the next section says the same thing
  • simplify release cycle section, per k8s style guide

other minor style changes:
  • put italics around the fact that Argo doesn't use SemVer -- just to be more explicit

  • replace use of jargon such as "shipped", per k8s style guide

  • use more consistent language as well

    • introduce RCs and capitalize the terms, then use the term RC
    • use "version" and "release" consistently
  • prefer 1 sentence per line of markdown, per style guide

  • fix some minor grammar issues (missing articles, extra comma, etc)

Verification

make docs passes

- did a full style guide audit of this page too, similar to my previous PRs, but there wasn't _too_ much to change here

- put italics around the fact that Argo doesn't use SemVer -- just to be _more_ explicit
- remove duplicated note about breaking changes being listed in the upgrading guide
  - the next section says the same thing

- simplify release cycle section, per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#use-simple-and-direct-language)
- replace use of jargon such as "shipped", per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#avoid-jargon-and-idioms)
- use more consistent language as well
  - introduce RCs and capitalize the terms, then use the term RC
  - use "version" and "release" consistently

- prefer 1 sentence per line of markdown, per [style guide](https://argo-workflows.readthedocs.io/en/release-3.5/doc-changes/)
- fix some minor grammar issues (missing articles, extra comma, etc)

Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Jun 2, 2024
Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 requested review from Joibel and juliev0 June 2, 2024 04:08
@juliev0 juliev0 merged commit 85c8832 into argoproj:main Jun 2, 2024
16 checks passed
@agilgur5 agilgur5 deleted the docs-copy-edit-releases branch June 2, 2024 04:27
agilgur5 added a commit that referenced this pull request Jun 14, 2024
Signed-off-by: Anton Gilgur <[email protected]>
(cherry picked from commit 85c8832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants